Feature/libusb #242

magnusja · 2020-01-10T14:19:58Z

No description provided.

codecov · 2020-01-10T19:20:14Z

Codecov Report

Merging #242 into develop will decrease coverage by 0.06%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           develop    #242      +/-   ##
==========================================
- Coverage    62.86%   62.8%   -0.07%     
==========================================
  Files           49      49              
  Lines         1570    1570              
  Branches       216     217       +1     
==========================================
- Hits           987     986       -1     
- Misses         518     519       +1     
  Partials        65      65

Impacted Files	Coverage Δ
...a/com/github/mjdev/libaums/fs/FileSystemFactory.kt	`100% <ø> (ø)`	⬆️
...a/com/github/mjdev/libaums/usb/UsbCommunication.kt	`0% <ø> (ø)`	⬆️
...ithub/mjdev/libaums/usb/UsbCommunicationFactory.kt	`0% <0%> (ø)`	⬆️
...ithub/mjdev/libaums/usb/AndroidUsbCommunication.kt	`0% <0%> (ø)`	⬆️
...ithub/mjdev/libaums/driver/scsi/ScsiBlockDevice.kt	`0% <0%> (ø)`	⬆️
...m/github/mjdev/libaums/fs/fat32/FsInfoStructure.kt	`76.19% <0%> (-4.77%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909b79e...ef76d6f. Read the comment docs.

depau · 2020-01-10T20:31:15Z

libusbcommunication/src/main/java/me/jahnen/libaums/libusbcommunication/LibusbCommunication.kt

+//        val ret = nativeClaimInterface(libUsbHandle, usbInterface.id)
+//        if (ret < 0) {
+//            throw IOException("libusb returned $ret in claim interface")
+//        }
+        val claim = deviceConnection!!.claimInterface(usbInterface, true)
+        if (!claim) {
+            throw IOException("could not claim interface!")
+        }


Why can't libusb claim it? I'm worried this may cause issues because I've seen it internally does unclaim/claim in reset_device, for example.

magnusja · 2020-01-10T20:46:01Z

Why exactly I have not figured out yet. But I got some device not connected error for the function call detaching the kernel driver and then a device busy error for claiming the usb device using libusb. But feel free to play around with that. The other thing is that some stuff just does not work (eg iterating the usb devices ) from libusb because of androids permission system.

…

On 10. Jan 2020, at 21:31, Davide Depau ***@***.***> wrote: @depau commented on this pull request. In libusbcommunication/src/main/java/me/jahnen/libaums/libusbcommunication/LibusbCommunication.kt: > +// val ret = nativeClaimInterface(libUsbHandle, usbInterface.id) +// if (ret < 0) { +// throw IOException("libusb returned $ret in claim interface") +// } + val claim = deviceConnection!!.claimInterface(usbInterface, true) + if (!claim) { + throw IOException("could not claim interface!") + } Why can't libusb claim it? I'm worried this may cause issues because I've seen it internally does unclaim/claim in reset_device, for example. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

depau · 2020-01-11T03:57:54Z

Yes, I figured listing devices wouldn't work, but I didn't expect the claiming process would require assistance from the system. I didn't get the chance to test :/ maybe within a few days

magnusja · 2020-01-11T15:01:41Z

I did not put too much time into that, so maybe we are still missing something to claim the interface using libusb. I guess one easy test would be to try claiming with a rooted device to see if it is really a permission problem.

magnusja · 2020-01-11T15:02:54Z

I think internally it tries to claim/unclaim sometimes but the code I have seen does usually ignore errors from claiming and just proceeds.

magnusja · 2020-01-11T15:48:05Z

libusbcommunication/src/main/java/me/jahnen/libaums/libusbcommunication/LibusbCommunication.kt

-//        val ret = nativeClaimInterface(libUsbHandle, usbInterface.id)
-//        if (ret < 0) {
-//            throw IOException("libusb returned $ret in claim interface")
-//        }
        val claim = deviceConnection!!.claimInterface(usbInterface, true)


@depau so this seems to work

magnusja · 2020-01-11T16:04:37Z

I made some tests with a usb hub and two drives, which usually never worked. With libusb this works quite well, so I hope that you will come to the same conclusion :)
(Although I have not seen the reset procedure, I think)

magnusja · 2020-01-11T23:34:24Z

libaums/src/main/java/com/github/mjdev/libaums/usb/UsbCommunicationFactory.kt

    }
 }
+
+interface UsbCommunicationCreator {


Issue found: UndocumentedPublicClass - [UsbCommunicationCreator] at /src/libaums/src/main/java/com/github/mjdev/libaums/usb/UsbCommunicationFactory.kt:73:1

magnusja · 2020-01-11T23:34:25Z

libaums/src/main/java/com/github/mjdev/libaums/usb/UsbCommunicationFactory.kt


 /**
 * Created by magnusja on 21/12/16.
 */

 object UsbCommunicationFactory {
+    class NoUsbCommunicationFound : IOException()


Issue found: UndocumentedPublicClass - [NoUsbCommunicationFound] at /src/libaums/src/main/java/com/github/mjdev/libaums/usb/UsbCommunicationFactory.kt:19:5

magnusja · 2020-01-11T23:34:26Z

libusbcommunication/src/main/java/me/jahnen/libaums/libusbcommunication/LibusbCommunication.kt

+    private external fun nativeClose(handle: Long, interfaceNumber: Int)
+    private external fun nativeReset(handle: Long)
+    private external fun nativeClearHalt(handle: Long, interfaceNumber: Int)
+    private external fun nativeBulkTransfer(handle: Long, endpointAddress: Int, data: ByteArray, offset: Int, length: Int, timeout: Int): Int


Issue found: LongParameterList - 6/6 - [nativeBulkTransfer] at /src/libusbcommunication/src/main/java/me/jahnen/libaums/libusbcommunication/LibusbCommunication.kt:38:44

magnusja · 2020-01-11T23:34:27Z

libusbcommunication/src/main/java/me/jahnen/libaums/libusbcommunication/LibusbCommunication.kt

+import java.nio.ByteBuffer
+import kotlin.math.absoluteValue
+
+class LibusbCommunication(


Issue found: UndocumentedPublicClass - [LibusbCommunication] at /src/libusbcommunication/src/main/java/me/jahnen/libaums/libusbcommunication/LibusbCommunication.kt:12:1

magnusja · 2020-01-11T23:34:28Z

libusbcommunication/src/main/java/me/jahnen/libaums/libusbcommunication/LibusbCommunication.kt

+
+}
+
+class LibusbCommunicationCreator : UsbCommunicationCreator {


Issue found: UndocumentedPublicClass - [LibusbCommunicationCreator] at /src/libusbcommunication/src/main/java/me/jahnen/libaums/libusbcommunication/LibusbCommunication.kt:63:1

magnusja · 2020-01-11T23:34:29Z

libusbcommunication/src/main/java/me/jahnen/libaums/libusbcommunication/LibusbCommunication.kt

+    private external fun nativeReset(handle: Long)
+    private external fun nativeClearHalt(handle: Long, interfaceNumber: Int)
+    private external fun nativeBulkTransfer(handle: Long, endpointAddress: Int, data: ByteArray, offset: Int, length: Int, timeout: Int): Int
+    private external fun nativeControlTransfer(handle: Long, requestType: Int, request: Int, value: Int, index: Int, buffer: ByteArray, length: Int, timeout: Int): Int


Issue found: LongParameterList - 8/6 - [nativeControlTransfer] at /src/libusbcommunication/src/main/java/me/jahnen/libaums/libusbcommunication/LibusbCommunication.kt:39:47

magnusja · 2020-01-11T23:34:29Z

libusbcommunication/src/main/java/me/jahnen/libaums/libusbcommunication/LibusbCommunication.kt

+import java.nio.ByteBuffer
+import kotlin.math.absoluteValue
+
+class LibusbCommunication(


Issue found: TooManyFunctions - 11/11 - [LibusbCommunication] at /src/libusbcommunication/src/main/java/me/jahnen/libaums/libusbcommunication/LibusbCommunication.kt:11:7

magnusja · 2020-01-11T23:34:30Z

libaums/src/main/java/com/github/mjdev/libaums/usb/UsbCommunicationFactory.kt

    }
 }
+
+interface UsbCommunicationCreator {
+    fun create(usbManager: UsbManager,


Issue found: UndocumentedPublicFunction - [create] at /src/libaums/src/main/java/com/github/mjdev/libaums/usb/UsbCommunicationFactory.kt:74:5

depau · 2020-01-12T10:56:54Z

I'm testing it and it's doing great! I'll see how it does on QEMU if my tiny RAM allows it

depau · 2020-01-12T12:32:14Z

I tested it on my two phones and on QEMU with a real USB drive passed through, it's working much better than the Android API implementation.

Still not working on QEMU with an emulated drive, it times out: https://pastebin.com/iGxQCz0k

I'm still not aware of what's wrong with it, it works fine if I pass-through a real USB drive, the emulated one works with Linux but not in userspace.

magnusja · 2020-01-12T12:55:13Z

Hey @depau

thanks a lot for testing! Awesome, that is good news. Then I will merge this and prepare a release so that other people can test this as well.

Regarding QEMU: Well that is unfortunate. If the emulated drive does not work in userspace in Linux the same problem might be in Android then as well. Can you maybe provide me with information on running QEMU, so that I can play around with this as well?

magnusja added 6 commits January 10, 2020 13:28

compile libusb

a219f4a

try to read usb devices using libusb

1a890d6

control and bulk transfers

97feaaa

claim interface

27f2bb4

refactor api little bit

5692d37

clear halt and reset devixce over libusb

2c50956

magnusja mentioned this pull request Jan 10, 2020

Could not write to device, result == -1 errno 0 null #237

Open

magnusja added 7 commits January 10, 2020 19:23

download libusb on travis

723ed53

rename

a6cd36e

try again

d1735bb

once again

9dcfdc2

android ci

edbb741

android ci

c5a2117

android ci libusb path

20a4746

depau reviewed Jan 10, 2020

View reviewed changes

claiming in libusb seems to work when claimed by Android before

f841799

magnusja commented Jan 11, 2020

View reviewed changes

uncomment other usb communications

ef76d6f

magnusja commented Jan 11, 2020

View reviewed changes

magnusja merged commit f9cd1cd into develop Jan 12, 2020

magnusja deleted the feature/libusb branch January 12, 2020 12:55

depau mentioned this pull request Jan 12, 2020

"Error setting up the device" on QEMU #209

Closed

This was referenced May 13, 2020

Error transferring command; errno 0 null #253

Open

can libaums support multiple devices connect simultaneously #71

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/libusb #242

Feature/libusb #242

magnusja commented Jan 10, 2020

codecov bot commented Jan 10, 2020 •

edited

Loading

depau Jan 10, 2020

magnusja commented Jan 10, 2020 via email

depau commented Jan 11, 2020

magnusja commented Jan 11, 2020

magnusja commented Jan 11, 2020

magnusja Jan 11, 2020

magnusja commented Jan 11, 2020

magnusja Jan 11, 2020

magnusja Jan 11, 2020

magnusja Jan 11, 2020

magnusja Jan 11, 2020

magnusja Jan 11, 2020

magnusja Jan 11, 2020

magnusja Jan 11, 2020

magnusja Jan 11, 2020

depau commented Jan 12, 2020

depau commented Jan 12, 2020

magnusja commented Jan 12, 2020


		}

		class LibusbCommunicationCreator : UsbCommunicationCreator {

Feature/libusb #242

Feature/libusb #242

Conversation

magnusja commented Jan 10, 2020

codecov bot commented Jan 10, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

magnusja commented Jan 10, 2020 via email

depau commented Jan 11, 2020

magnusja commented Jan 11, 2020

magnusja commented Jan 11, 2020

Choose a reason for hiding this comment

magnusja commented Jan 11, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

depau commented Jan 12, 2020

depau commented Jan 12, 2020

magnusja commented Jan 12, 2020

codecov bot commented Jan 10, 2020 •

edited

Loading